PImage… a peer-review

As i wrote in my 0.8 plan, I will be getting as much peer-reviews in as needed. PImage has been written, rewritten, reviewed, and re-reviewed. Altogether i has been a mess and I soooo love dhodgin for taking it off my hands. I spent a majority of last semester trying to get it working with no success. Finally, with humph’s help, PImage has been rewritten to load asynchronous images. The copy() and blend() functionality has also been added. I believe the only things left are save() mask() and filter() which I am sure will come together soon.

Initially, I had to fail the review because there were some lint errors and some examples were not working. However, ultimately the patch did pass on to super-review.

The basis for my decision:

  • the function returns the appropriate value.
  • the function is written following the coding standards . Using 2 spaces instead of a tab, and leaving a space around brackets
  • there is tests available to test the function

View all of my blogs on Processing.js
View all of my blogs

Advertisements

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s