applyMatrix()… a peer-review

As I stated before in my post, I will be performing some peer-reviews for my 0.6 release. Today I looked at applyMatrix() coded by aSydik. Here is a link to the lighthouse ticket, the processing reference and the JAVA code I used to decide what the function is suppose to return. This is my second review of applyMatrix(), the first time I reviewed it I had to fail it and set it to review-needs-work. This was because the example that can be found on the processing reference page did not work as it was suppose to. Now, aSydik (Mickael Medel) has fixed the problem and put up a link to his test. Check it out.

he basis for my decision:

  • the function returns the appropriate value.
  • the function is written following the coding standards . Using 2 spaces instead of a tab, and leaving a space around brackets
  • there is tests available to test the function

After reviewing the code I gave applyMatrix() the status of super-review-requested.

View all of my blogs on Processing.js
View all of my blogs

Advertisements

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s