modelX()… a peer-review

As I stated before in my post, I will be performing some peer-reviews for my 0.6 release. Today I looked at modelX() coded by asalga. Here is a link to the lighthouse ticket, the processing reference, and the JAVA code I used to decide what the function is suppose to return. I compared the Java and the processing.js code that Andor (asalga) wrote and it is more or less the same. I also recreated the test found on the processing reference site. Here is a screen shot:

Im sure you have noticed that the box is white and not see-threw and that the outline is black. This is due to the fact that the box() function does not yet make use of 3D fill and 3D stroke. This has nothing to do with the modelX() code i am reviewing.

The basis for my decision:

  • the function returns the appropriate value.
  • the function is written following the coding standards . Using 2 spaces instead of a tab, and leaving a space around brackets
  • there is tests available to test the function

After reviewing the code I gave modelX() the status of super-review-requested.

View all of my blogs on Processing.js
View all of my blogs

Advertisements

One thought on “modelX()… a peer-review

  1. Pingback: modelZ()… a peer-review « Anna on Computing

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s