As I stated before in my post, I will be performing some peer-reviews for my 0.5 release. Today I looked at the min() and max() coded by mlam19. Here is a link to the lighthouse ticket, the processing reference for min and max, and the JAVA code I used to decide what the function is suppose to return. Matthew wrote 4 different sets of test for these functions which made it really easy to test. Here are the links: min1, min2, max1, max2.
The basis for my decision:
- the function returns the appropriate value.
- the function is written following the coding standards . Using 2 spaces instead of a tab, and leaving a space around brackets
- there is tests available to test the function
After reviewing the code I gave both min() and max() the status of super-review-requested.