As I stated before in my post, I will be performing some peer-reviews for my 0.5 release. Today I looked at hex() coded by dhodgin. Here is a link to the lighthouse ticket, the processing reference, and the JAVA code I used to decide what the function is suppose to return. Technically, mlam19 already did a review of this function, but since there are known issues I decided to look at the test again. If you look at the test you will see that tests results differ in Java: b3, c2, cl1-cl4. I left a note in the lighthouse ticket to be reviewed by the super reviewer.
The basis for my decision:
- the function returns the appropriate value.
- the function is written following the coding standards . Using 2 spaces instead of a tab, and leaving a space around brackets
- there is tests available to test the function
After reviewing the code I gave hex() the status of super-review-requested.