strokeJoin()…a peer-review

As I stated before in my post, I will be performing some peer-reviews for my 0.5 release. Today I looked at strokeJoin() coded by mlam19. Here is a link to the lighthouse ticket, the processing reference, and the JAVA code I used to decide what the function is suppose to return. I took some time looking at the code and the strokeJoin test that mlam19 wrote. Comparing the code written by mlam19 and the Java code it looks exactly the same except for some if statements.   Here is a screen shot comparing the Java output to mlam19’s test:

The basis for my decision:

  • the function returns the appropriate value.
  • the function is written following the coding standards . Using 2 spaces instead of a tab, and leaving a space around brackets
  • there is tests available to test the function

After reviewing the code I gave strokeJoin() the status of super-review-requested.

View all of my blogs on Processing.js
View all of my blogs

Advertisements

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s