As I stated before in my post, I will be performing peer-reviews for my 0.4 release. Today I looked at curve() coded by Dliu53. Here is a link to the lighthouse ticket, the processing reference, and the JAVA code I used to decide what the function is suppose to return. Even though I already wrote this function, I decided to look at this code to ensure that it is similar to mine. Comparing the code written by Dliu53 and the Java code it looks exactly the same. I looked at Dliu53 curveTangent() test and the results looks the same as the output of the Java 1.0.7 environment. Here is a screen shot comparing the Java output to Dliu53’s test:
The basis for my decision:
- the function returns the appropriate value.
- the function is written following the coding standards . Using 2 spaces instead of a tab, and leaving a space around brackets
After reviewing the code I gave curve() the status of super-review-requested.