boolean()…a peer-review

As I stated in my last post, I will be performing peer-reviews for my 0.4 release. I started today by going over boolean() coded by Matthew Lam. Here is a link to the lighthouse ticket, the processing reference, and the JAVA code I used to decide what the function is suppose to return. At first I though that the function can use the JavaScript boolean() object. However, after some Java Processing comparison I figured that the two do not work the same. For example in JavaScript var myBoolean=new Boolean(“false”); would return true but in Java it would return false.

The basis for my decision:

  • the function returns the appropriate value. I tested it using my own tests even though Matthew Lam’s test is FANTASTIC!!
  • the function is written following the coding standards . Using 2 spaces instead of a tab, and leaving a space around brackets

After reviewing the code I gave boolean() the status of super-review-needed

View all of my blogs on Processing.js
View all of my blogs

Advertisements

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s